Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find edges shared between polygons and simplify them individually #302

Merged
merged 18 commits into from
Oct 14, 2016
Merged

Find edges shared between polygons and simplify them individually #302

merged 18 commits into from
Oct 14, 2016

Commits on Oct 6, 2016

  1. Add a critical point where the set of rings using a polygon edge changes

    @e-n-f
    e-n-f committed Oct 6, 2016
    Configuration menu
    Copy the full SHA
    f7daa05 View commit details
    Browse the repository at this point in the history

  2. Roll rings around so they start at an intersection transition, if any

    @e-n-f
    e-n-f committed Oct 6, 2016
    Configuration menu
    Copy the full SHA
    2bc9e15 View commit details
    Browse the repository at this point in the history

  3. Find a common-edge transition if it's the first point of the ring

    @e-n-f
    e-n-f committed Oct 6, 2016
    Configuration menu
    Copy the full SHA
    6b40766 View commit details
    Browse the repository at this point in the history

  4. Crunch out zero-length linetos to improve the match

    @e-n-f
    e-n-f committed Oct 6, 2016
    Configuration menu
    Copy the full SHA
    59619fb View commit details
    Browse the repository at this point in the history

  5. Choose a consistent starting point for rings with no shared edges

    @e-n-f
    e-n-f committed Oct 6, 2016
    Configuration menu
    Copy the full SHA
    91bfc2c View commit details
    Browse the repository at this point in the history

  6. Most of the way toward TopoJSON-style factoring out of edges

    @e-n-f
    e-n-f committed Oct 6, 2016
    Configuration menu
    Copy the full SHA
    57cc343 View commit details
    Browse the repository at this point in the history

  7. If a point divides one border, it divides any that touch there

    @e-n-f
    e-n-f committed Oct 6, 2016
    Configuration menu
    Copy the full SHA
    d35dc49 View commit details
    Browse the repository at this point in the history

  8. Extract common edges, simplify, then reassemble polygon rings

    @e-n-f
    e-n-f committed Oct 6, 2016
    Configuration menu
    Copy the full SHA
    2b42806 View commit details
    Browse the repository at this point in the history

  9. Remove more debugging code

    @e-n-f
    e-n-f committed Oct 6, 2016
    Configuration menu
    Copy the full SHA
    938274a View commit details
    Browse the repository at this point in the history

  10. Remember to honor --no-line-simplification if it was requested

    @e-n-f
    e-n-f committed Oct 6, 2016
    Configuration menu
    Copy the full SHA
    6455b66 View commit details
    Browse the repository at this point in the history

  11. Remember to close the polygon

    @e-n-f
    e-n-f committed Oct 6, 2016
    Configuration menu
    Copy the full SHA
    46b634c View commit details
    Browse the repository at this point in the history

  12. Save a little time by only looking up each segment once

    @e-n-f
    e-n-f committed Oct 6, 2016
    Configuration menu
    Copy the full SHA
    4c1b135 View commit details
    Browse the repository at this point in the history

  13. A sorted list is smaller and faster than a map of sets

    @e-n-f
    e-n-f committed Oct 6, 2016
    Configuration menu
    Copy the full SHA
    7258643 View commit details
    Browse the repository at this point in the history

  14. Rename option to --detect-shared-borders and add a test

    @e-n-f
    e-n-f committed Oct 6, 2016
    Configuration menu
    Copy the full SHA
    896c9d8 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2016

  1. Lots of debug output to try to track down Mac/Linux differences

    @e-n-f
    e-n-f committed Oct 14, 2016
    Configuration menu
    Copy the full SHA
    a5d803a View commit details
    Browse the repository at this point in the history

  2. Guard against uninitialized variables

    @e-n-f
    e-n-f committed Oct 14, 2016
    Configuration menu
    Copy the full SHA
    9160e6a View commit details
    Browse the repository at this point in the history

  3. Stabilize edge list order by also comparing ring IDs

    @e-n-f
    e-n-f committed Oct 14, 2016
    Configuration menu
    Copy the full SHA
    feb9b44 View commit details
    Browse the repository at this point in the history

  4. Remove debug output

    @e-n-f
    e-n-f committed Oct 14, 2016
    Configuration menu
    Copy the full SHA
    71bf20b View commit details
    Browse the repository at this point in the history