Enable library evolution and prepare v2.0.0-alpha.2 #133
Conversation
macdrevx
commented
Feb 9, 2021
macdrevx
commented
- Enables library evolution in the Xcode project
- Enables library evolution in the podspec
- Updates version numbers for v2.0.0-alpha.2 release
- Configures build settings for generating XCFrameworks
- Adds a script to generate an XCFramework
- Configures the Package.swift to use binary distribution
- Disables SKIP_INSTALL - Adds scripts/create-xcframework.sh which can be used for consistent, XCFramework generation.
| pushd "$TURF_BUILD_DIR" | ||
| zip -r "Turf.xcframework.zip" "Turf.xcframework" | ||
| popd | ||
|
|
There was a problem hiding this comment.
is this something we'd want to make part of CI. Or leave it as is since the xcframework is a stop gap?
There was a problem hiding this comment.
Let's leave it as-is since it's a stop gap solution. I included it for transparency so that anyone can see how the XCFramework was generated.
There was a problem hiding this comment.
The build setting change and limited platform support would normally be unmergeable. However, this PR targets a branch from which we’ll tag an alpha that’s specifically intended as a stopgap to unblock mapbox/mapbox-navigation-ios#2629 and mapbox/mapbox-navigation-ios#2794 for a prerelease. Once the map SDK migrates to source-based distribution, this branch and the corresponding one in mapbox-directions-swift will go away and we’ll continue to build as before.
It looks like the rest of the changes are consistent with running scripts/update-version.sh.
|
|
||
| let package = Package( | ||
| name: "Turf", | ||
| platforms: [.iOS(.v10), .macOS(.v10_12)], |
There was a problem hiding this comment.
Is this binary being built for macOS? If not, remove that item from the array to make incompatibility clearer to anyone who accidentally ends up with this prerelease.
Turf and MapboxDirections both support macOS, tvOS, watchOS, and Linux in addition to iOS. Normally we would not be able to regress support for these platforms, but we’ll do so for this alpha only.
There was a problem hiding this comment.
The binary was built for iOS and macOS.
|
FYI, Linux builds are failing because they’re still on Swift 5, whereas this PR now requires Swift 5.3: Feel free to address that issue if you’re familiar with Travis configuration, but otherwise you can merge without getting those builds to pass, since this PR would break support for Linux anyways. |
