Support visionOS target #213
Conversation
persidskiy
force-pushed
the
ps/vision-os
branch
2 times, most recently
from
7e66deb
to
9506d7b
Compare
persidskiy
force-pushed
the
ps/vision-os
branch
3 times, most recently
from
bff6acd
to
f5df956
Compare
persidskiy
force-pushed
the
ps/vision-os
branch
from
6cc7cbf
to
ad6c15b
Compare
persidskiy
force-pushed
the
ps/vision-os
branch
from
de68972
to
0e1f301
Compare
| type: string | ||
| macos: | ||
| xcode: 15.2.0 | ||
| resource_class: macos.m1.medium.gen1 |
There was a problem hiding this comment.
visionOS simulator is only supported on M1
| @@ -24,6 +24,9 @@ Pod::Spec.new do |s| | |||
| s.osx.deployment_target = "10.13" | |||
| s.tvos.deployment_target = "11.0" | |||
| s.watchos.deployment_target = "4.0" | |||
| # CocoaPods doesn't support releasing of visionOS pods yet, need to wait for v1.15.0 release of CocoaPods | |||
| # with this fix https://github.com/CocoaPods/CocoaPods/pull/12159. | |||
| # s.visionos.deployment_target = "1.0" | |||
There was a problem hiding this comment.
Having this fails the pod spec lint with the following error:
- ERROR | [visionOS] unknown: Encountered an unknown error (Could not find a `visionos` simulator (valid values: ios, tvos, watchos, xros). Ensure that Xcode -> Window -> Devices has at least one `visionos` simulator listed or otherwise add one.) during validation.
I think it's fine not to support VisionOS for CocoaPods distribution for a while.
There was a problem hiding this comment.
Can we use the main branch of CocoaPods for releases for now? Not sure if it will break integration for customers with pre-1.15 CocoaPods
There was a problem hiding this comment.
They say it doesn't work still CocoaPods/CocoaPods#12159 (comment)
If nobody fixes it and I have time, I'll try to fix it myself.
| @@ -1,12 +1,12 @@ | |||
| // swift-tools-version:5.5 | |||
| // swift-tools-version:5.7 | |||
There was a problem hiding this comment.
We could leave this file unmodified and create a separate one named Package@swift-5.7.swift, but it's probably okay to drop Xcode 13 support already.
There was a problem hiding this comment.
Yeah, that was initial idea, but then it's a duplicate and swift build was failing. So I decided it worth to update xcode requirement, as it xcode 13 is not supported in appstore anyway.
| @@ -24,6 +24,9 @@ Pod::Spec.new do |s| | |||
| s.osx.deployment_target = "10.13" | |||
| s.tvos.deployment_target = "11.0" | |||
| s.watchos.deployment_target = "4.0" | |||
| # CocoaPods doesn't support releasing of visionOS pods yet, need to wait for v1.15.0 release of CocoaPods | |||
| # with this fix https://github.com/CocoaPods/CocoaPods/pull/12159. | |||
| # s.visionos.deployment_target = "1.0" | |||
There was a problem hiding this comment.
Can we use the main branch of CocoaPods for releases for now? Not sure if it will break integration for customers with pre-1.15 CocoaPods
This PR supports visionOS target.
It also bumps the minimal xcode version to 14.1. This is required to use
.custom("visionOS", versionString: "1.0")in spm, which is supported starting from swift 5.6. However, I decided it's safe to bump the minimal swift version to 5.7, as Xcode 14.1 is the minimal supported version for AppStore distribution.Also, added CI test runs on iOS and visionOS simulators.