Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return feature.id in response #90

Merged
merged 4 commits into from
Jun 23, 2018
Merged

Return feature.id in response #90

merged 4 commits into from
Jun 23, 2018

Conversation

springmeyer
Copy link
Contributor

This:

  • Starts returning the feature.id in the response per
  • Adds a new fixture for coverage of non-zero feature ids
  • Adds process.env.UPDATE to make it easy to update the fixtures in the future (if needed)

If a Feature has a commonly used identifier, that identifier SHOULD be included as a member of the Feature object with the name "id", and the value of this member is either a JSON string or number.

From https://tools.ietf.org/html/rfc7946#section-3.2

/cc @mapbox/core-tech

@springmeyer
Copy link
Contributor Author

Looks like tests are all failing on linux and only passing on OS X (https://travis-ci.org/mapbox/vtquery/builds/395219301). Sorting is probably the culprit, but not sure yet. Will need to re-read #44 to see if that could be related.

@springmeyer
Copy link
Contributor Author

Using std::stable_sort to debug this over in e518d71.

@springmeyer
Copy link
Contributor Author

Stable sort changed results locally on OS X, but looks like it means the results are stable between OS X and Linux now: https://travis-ci.org/mapbox/vtquery/builds/395225756

@springmeyer springmeyer mentioned this pull request Jun 21, 2018
1 task
@springmeyer springmeyer added this to the 0.2.2 milestone Jun 23, 2018
@springmeyer springmeyer merged commit 6cd8752 into master Jun 23, 2018
@springmeyer springmeyer deleted the feature-id branch June 23, 2018 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant