Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest nan/node-pre-gyp + node v10 support #99

Merged
merged 2 commits into from
Jul 1, 2018
Merged

latest nan/node-pre-gyp + node v10 support #99

merged 2 commits into from
Jul 1, 2018

Conversation

springmeyer
Copy link
Contributor

This starts:

  • Building for node v10
  • Avoids new nan deprecation warnings
  • Stops bundling node-pre-gyp to avoid potential errors with different npm versions that have expectations about node_modules tree structure
  • Updates to latest node-pre-gyp

Closes #92.

@springmeyer springmeyer merged commit a25279d into master Jul 1, 2018
@springmeyer springmeyer deleted the node-v10 branch July 1, 2018 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant