Switch Windows builds of mapnik to using jpeg-turbo rather then standard jpeg library. #33
Comments
It this what's used on other platforms, too? As far as I've looked into it, it seems to require additional dependencies, we don't yet have:
At least I'm hitting a wall without those: Even, when building with Visual Studio the build process has to be started from the MYSYS shell. See docs about buildscripts: And which one of those do we need? |
Yes, this is what is used on osx + linux: https://github.com/mapnik/mapnik-packaging/blob/master/osx/scripts/build_jpeg_turbo.sh
Bizarre. Right, we only need the libjpeg (I think the final binary should be named jpeg.dll) it produces. Can you find anyone else that has been able to build just the libjpeg? I wonder how Chromium does it: do they use jpeg-turbo or the original libjpeg? |
I just made it work this very moment. These are the binaries I get: |
@BergWerkGIS - are we officially using jpeg-turbo now or does this still need finished? |
@springmeyer no, still using libjpeg. I'll look into it. |
Done. |
🙏 |
AppVeyor for |
YAYYYYYY: I've removed the hacks disabling or reducing the comparison threshold for jpeg image fixtures. And after using a Win SDK with jpeg-turbo all tests are still passing: https://ci.appveyor.com/project/Mapbox/node-mapnik/build/1.0.575 |
@BergWerkGIS could you look into this?
The text was updated successfully, but these errors were encountered: