Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text objects #230

Merged
merged 3 commits into from
Sep 7, 2022
Merged

Add text objects #230

merged 3 commits into from
Sep 7, 2022

Conversation

aleokdev
Copy link
Contributor

@aleokdev aleokdev commented Sep 6, 2022

How didn't we have these?? Major oversight :)

Merge after #229.

@aleokdev aleokdev added enhancement breaking This change breaks backwards-compatibility feature labels Sep 6, 2022
@bjorn
Copy link
Member

bjorn commented Sep 7, 2022

I'd suggest to rebase this PR now.

Copy link
Member

@bjorn bjorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two small comments.

src/objects.rs Outdated Show resolved Hide resolved
src/objects.rs Outdated Show resolved Hide resolved
@aleokdev
Copy link
Contributor Author

aleokdev commented Sep 7, 2022

Contains is unstable so this will have to do :)

bjorn
bjorn previously approved these changes Sep 7, 2022
@bjorn
Copy link
Member

bjorn commented Sep 7, 2022

Approved, but don't forget the changelog. :-)

@aleokdev aleokdev merged commit bfd67ca into mapeditor:next Sep 7, 2022
@aleokdev aleokdev deleted the text-objects branch September 7, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This change breaks backwards-compatibility enhancement feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants