Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move parsing functions to parse module #232

Draft
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

aleokdev
Copy link
Contributor

@aleokdev aleokdev commented Sep 7, 2022

WIP. This PR moves all internal functions to the parse module.
This has the advantage of providing a clear interface to the user & developers, as the structure of Tiled objects are now defined completely separate from how they are parsed. However, this PR still doesn't answer questions like "Should we make the parse functions public?" "How should we present the parse functions internally?" etc. For now the definitions have been moved literally to the XML/"common" module.

Stopped mid-way since I realized a huge mistake with wangsets (The WangSetType type isn't accessible from outside and the compiler didn't complain somehow, even with the wang_set_type public WangSet member). Fixing this now in current. I wish we'd have implemented wangsets in next instead. Oh well.

@aleokdev aleokdev changed the base branch from current to next September 7, 2022 10:29
@aleokdev aleokdev deleted the branch mapeditor:next March 16, 2023 17:29
@aleokdev aleokdev closed this Mar 16, 2023
@bjorn bjorn reopened this Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants