Move parsing functions to parse module #232
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP. This PR moves all internal functions to the parse module.
This has the advantage of providing a clear interface to the user & developers, as the structure of Tiled objects are now defined completely separate from how they are parsed. However, this PR still doesn't answer questions like "Should we make the parse functions public?" "How should we present the parse functions internally?" etc. For now the definitions have been moved literally to the XML/"common" module.
Stopped mid-way since I realized a huge mistake with wangsets (The
WangSetType
type isn't accessible from outside and the compiler didn't complain somehow, even with thewang_set_type
public WangSet member). Fixing this now incurrent
. I wish we'd have implemented wangsets innext
instead. Oh well.