Added dark theme #1027
Added dark theme #1027
Conversation
|
I can't make sense out of the build logs, are those errors caused by me or possibly something else? As a side note this pull request probably solves #786. |
|
AppVeyor is failing since recently because some checksum verification fails while installing NSIS. That's annoying and outside the scope of our project, so I hope somebody else will fix it soon. TravisCI is failing because it still tries to compile Tiled with Qt 4.8.1 even though the minimum supported version was raised to Qt 5.1.0. So, don't worry about those failures. I still need to check your changes, but thanks for doing this and I'm really curious how Tiled will look! I have a few initial requests:
|
Added Dark theme Removed unnecessary files
|
I hope I got those commits right and that you don't mind the secondary commit with the tabs replaced. Otherwise I think I fulfilled your request. I'll be waiting to hear from you about the actual code changes. |
| @@ -508,6 +508,10 @@ MainWindow::MainWindow(QWidget *parent, Qt::WindowFlags flags) | |||
| new QShortcut(key, this, SLOT(delete_())); | |||
| #endif | |||
|
|
|||
| Preferences *prefs = Preferences::instance(); | |||
There was a problem hiding this comment.
There is already a pointer to the preferences in this scope, called preferences.
|
I hope I caught all your requests, and thanks for taking the time of describing what you wanted to be changed. How's that looking now? |
| @@ -120,6 +120,7 @@ QtGuiApplication { | |||
| "createscalableobjecttool.h", | |||
| "createtileobjecttool.cpp", | |||
| "createtileobjecttool.h", | |||
| "darkstyle/style.qrc", | |||
There was a problem hiding this comment.
Please use spaces instead of tabs for indentation.
|
I really think Tiled should have a nice dark theme. Personally I don't really like this particular one, but it's probably better than not having a dark theme (though, anybody could have already used this theme by simply passing A few problems I see with this theme:
I hope we can address most these issues somehow. |
|
Yeah to be honest I'm not too happy with the particular theme either, but I felt like just adding something "close enough" would be fine for now... I'm not too interested in modifying the QSS file, but maybe if I notice somethings that I'd like to modify in my level-creation-workflow, I might take some time and modify the QSS where needed. I did not know about the command-line workaround, but I wonder if that would have worked with the custom images the theme supplies? Anyways, in my opinion having an okayish dark theme available is good enough for now, and at least there's an easy way to toggle it off if someone thinks that the problems with the theme are too annoying. But the decision of if you want this to Tiled at this state is of course yours, but as I said earlier, I don't really want to get in and modify the QSS, at least for now. E: Sorry if I'm sounding like a dick and not wanting to do any actual work. |
What about reporting some of these things to the original project, is that something you're interested in doing?
I think it could work, but you're right, the way the images are referenced currently assumes the whole thing is packed as a resource file and this does not work.
Well, I at least decided not to rush it into Tiled 0.13. Are you maybe aware of any alternatives dark themes for Qt that we could try? |
|
I for sure could try to look for alternative dark themes, and give them a try. Because I can't get Tiled to build in the QtCreator, I have to dev in Visual Studio which requires me to rebuild the whole VS Solution every time I change a *.pro file (link a theme resource file), so the process is not going to be very fast. Does the fact that you decided not to rush this for 0.13 mean that there's no real rush on this? I probably could work on this when I don't feel like developing my game. I would like to take this opportunity to thank you for all of your hard work on Tiled. The fact that I did not have to spend months building my own level editor for my games is a huge help. Tiled is awesome, but it's definitely missing a dark theme :) |
That sounds like a real pain. Any idea why you can't use Qt Creator?
Yes, there's no rush at all. If it should have gone into Tiled 0.13 I would have had to merge it yesterday since I announced the string freeze for the translators. And you're welcome for the level editor, it's been my pleasure developing it! The only reason I'm asking for donations is because otherwise I could not afford to spend much time on it, which is very frustrating. |
|
The Qt Creator doesn't compile *.moc files at all, which might maybe have something to do with wrong Qt version/setup. I might have to invest some time to see if I could get it to work, that would speed up stuff a lot (+ I could setup the Tiled indentation + style settings to Qt Creator and stop messing up the commits with my game-project settings which I've forgotten to change). BTW is there a style guide for Tiled somewhere? Nice to hear that I'm not in a rush. I'll get back to this (hopefully in a couple of days, but I can't promise anything) once I've made some progress. |
Hmm yes, that sounds very strange. I haven't heard about it before. Note that personally I'm using MinGW for the daily Windows builds, so that is at least tested to work (seems the NSIS installation problem is fixed). You might have more success with that, just in case the problems are due to some unexpected VS compiler setup. In addition I'm not using the
It's generally the Qt coding style. |
|
So I ended up starting to write a theme of my own. It's quite heavily influenced by the new Hammer-editor look, and while most of the QSS is my own, I also borrowed some from the initial darkstyle I included with the pull-request. It's still WIP, and looking like this: One issue I've been unable to solve is the "Visible" checkbox in the property editor. It doesn't update to the style unless it's clicked first. I found some related code in QtBoolEdit, but it looks like it's first just a placeholder checkbox? Any pointers on this? Some initial feedback on the theme is also welcome, but I'm really digging it and I will definitely use it for my to-come level editing. |
|
@Tyyppi77 Well, I like your theme better, mainly for being less dark in general I think. Two things I don't really like is that it seems to have a lot of borders, including borders around each icon (which I think would be better to do only in hover/pressed/selected states) and even a border around the "Opacity:" label. Personally, I would probably try to copy the style of Photoshop CS 6. I really like how it is not actually very dark, and it looks clean:
|
This checkbox is special in that it is not really a QCheckbox widget. Rather it is just being painted as one, which might explain why it is not properly being styled by a stylesheet. Fortunately, this is also a checkbox I want to get rid of, because I'd rather have an eye icon there to make it much clearer that this is for toggling the layer visibility. Both Photoshop and GIMP also use an eye icon for this purpose. |
|
I liked the idea of new themes ... Which or what are the files that need to be altered to change the theme used in the Tiled? |
|
Yeah I kinda dropped the idea, as I lost motivation after the first boost. However if someone is interested, I can share the QSS files I used for the theme in the last screenshot I posted. |
|
I'll close this PR since I'm instead working on a dark theme based on the Fusion theme. See #786 for the progress on that. |
I added a dark theme to Tiled that can be toggled from the preference dialog. The dark theme I used is from here (https://github.com/ColinDuquesnoy/QDarkStyleSheet). This is my first time contributing, so I apologize for any problems/issues this might bring up.