Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to choose a custom interface font #3589

Merged
merged 6 commits into from
Feb 27, 2023

Conversation

bjorn
Copy link
Member

@bjorn bjorn commented Feb 24, 2023

image

Closes #3569

@eishiya
Copy link
Contributor

eishiya commented Feb 24, 2023

Just so this info is easier to find: On Windows 10, the custom font doesn't apply to many elements.

The menu bar, including menu contents, panel names and contents on the darker backgrounds aren't affected:
image

In the keyboard shortcut list, the overridden entries use the custom font, but the others do not:
image
The plugins list is also unaffected.

The issue counter is not affected initially (see first screenshot), but becomes affected after a restart:
image
This is the only bit I noticed being "fixed" by restarting.

* Use QApplication::setFont instead of QGuiApplication::setFont.

* Override font used for QDockWidget titles, so that it doesn't use a
  font saved in QDockWidgetPrivate that is never updated.

* Fixed IssuesCounter to use widget font instead of application font.

* Moved applying of font settings to StyleHelper and moved initialization
  of StyleHelper to before the MainWindow gets constructed.
Just using QFont default constructor is usually enough.
@bjorn bjorn merged commit 4fc45ab into mapeditor:master Feb 27, 2023
@bjorn bjorn deleted the font-setting branch February 27, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow explicit control over the application font
2 participants