Scripting: add displayImage property to Tile to get pre-cropped image #3960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While this looks like a useful addition, I'm not sure if it really makes sense to add it is almost trivially supported by the existing API as follows: let rect = tile.imageRect;
let displayImage = tile.image.copy(rect.x, rect.y, rect.width, rect.height);Though I realize the existing behavior of |
bjorn
added a commit
to bjorn/tiled-dev
that referenced
this pull request
Jun 14, 2024
Since Tile.image can refer to a larger image, to get only the part representing the tile one needs to make a copy. See mapeditor#3960
bjorn
added a commit
that referenced
this pull request
Jun 17, 2024
Also provided a snippet to get a tile's image, since Tile.image can refer to a larger image that needs to be cropped using Tile.imageRect. See #3960
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw #3918 is marking these as
@since 1.11, so I did the same here, but I could change it.The idea here was to provide a pre-cropped image (since
Tile.imagereturns the full image) so that you could display it on a dialog. It came up when I was asking if a new type of widget that lets you select & preview a tile (a TileButton like a color picker button) might be useful.Let me know what you think
Example script:
https://gist.github.com/dogboydog/363a4fec2e7b1c408e9ecc4b93234bde
Example images
