Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove magic number: 1 in ImageSimilarity #3024

Open
sebr72 opened this issue Aug 15, 2023 · 0 comments
Open

Remove magic number: 1 in ImageSimilarity #3024

sebr72 opened this issue Aug 15, 2023 · 0 comments

Comments

@sebr72
Copy link
Contributor

sebr72 commented Aug 15, 2023

Following Code review of PR 3008 in master. It was identified that the ImageSimilarity is using a max distance of 1, which is no longer expected (as CI and dev should be running in Docker and always give a max distance of 0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sebr72