This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Properly size the canvas based on image size and rotation angle #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The icon.html example shows a rotating Linux icon (512x512) with no clipping. Before the change, only the central portion of the icon would be visible. Linux demo icon comes from http://www.softicons.com/toolbar-icons/programmers-pack-icons-by-iconshock/linux-icon and is licensed as freeware.
adube
suggested changes
Sep 4, 2019
There was a problem hiding this comment.
If you look at the icon.html example from your branch, you'll see that the small icon is clipped.
If you look at the same example from master, it's not clipped.
I haven't looked deeper at why, but would you please take a look to try to figure what's wrong?
Thanks.
|
OK, will check and get back to you. Thanks @adube ! |
Include the anchor offset in the canvas width & height determination. Updated example to show effect.
|
This update now takes into account the anchor offsets, fixing the problem seen. |
|
Thanks. I should be able to test the patch again this weekend. |
adube
approved these changes
Sep 7, 2019
|
Merci Alexandre ! Thanks for providing and maintaining this library for the community ! |
|
Thanks :) Thanks to you and every contributor as well! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation used for rendering images does not handle correctly images whose width or height exceed a default value (around 300 pixels in width/height). This results in the image being clipped when displayed. This is even more evident when the image is rotated as this increases the effective canvas size requirements.
The changes are fixes for this limitation. The fix is demonstrated in the modified version of the icon.html example. To see the effect, first run the updated version of the example without the fix applied. Then compare with the fix applied.