Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multipolygon geometry support in Tag component #242

Closed
8 tasks
oscarlorentzon opened this issue May 2, 2017 · 4 comments
Closed
8 tasks

Multipolygon geometry support in Tag component #242

oscarlorentzon opened this issue May 2, 2017 · 4 comments

Comments

@oscarlorentzon
Copy link
Member

The tag component should support showing, editing and creating multipolygons. Needed for instance aware segmentations where an instance is split over multiple areas.

  • Multipolygon geometry class working in perspective images
  • Multipolygon geometry class working in panoramas
  • Unit tests
  • Create new geometries
  • Edit vertices of geometries
  • Add new vertices to existing geometries
  • Remove vertices from existing geometries
  • Fill
@mrAceT
Copy link

mrAceT commented Sep 13, 2019

Looks like you did it ;)
https://bl.ocks.org/oscarlorentzon/94539cefc33296ab6f28e3a83ecdccf1
https://bl.ocks.org/oscarlorentzon/a9ad92a720d2f175c9ce7f3f982ac59f

when I place a new Mapillary.MarkerComponent.CircleMarker I use lat/lon
Is it possible to convert lat/lon to the coordinate system for a polygon?

PS: my apologies if my question should not be asked here

@oscarlorentzon
Copy link
Member Author

@mrAceT Currently it is not possible.

I added an issue about creating an API method related to your question, see #296.

@mrAceT
Copy link

mrAceT commented Sep 16, 2019

Great!

When it would then be possible to draw a polyline (with options *) feeding it lat/lon values, that would be awesome!

That way I would be able to show the path an image set follows!

*) options like width, transparency etc. When it would be possible to set a flag like use "one-point perspective" that would be perfect!

PS: the result would be a Multipolygon, but it would save the user an hefty amount of calculation..

@oscarlorentzon
Copy link
Member Author

Creating and editing tags will not be prioritized going forward.

Creating and rendering 3D objects (like line geometries corresponding to lng, lat values) is possible through the custom render API in v4.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants