Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Library crashes for images that have not yet been SfM merged #297

Closed
oscarlorentzon opened this issue Sep 19, 2019 · 0 comments
Closed

Library crashes for images that have not yet been SfM merged #297

oscarlorentzon opened this issue Sep 19, 2019 · 0 comments
Assignees
@oscarlorentzon
Labels
bug
Milestone
2.18.1

Comments

@oscarlorentzon
Copy link
Member

Basic information

MapillaryJS version: 2.17.0
System/Browser: All

Steps to Reproduce Behavior

  1. Navigate to an image that has not been SfM merged (recently uploaded)

Expected behavior

Library does not throw exceptions

Actual behavior

Library throws exception that is not handled internally, leading to crashes and black screens.

Additional information

Introduced in 91f03cc#diff-4024083bb9eb05981875d864aa3f6975R57 because of the call to Node.computedLatLon which is undefined for non merged nodes.
@oscarlorentzon oscarlorentzon self-assigned this Sep 19, 2019
@oscarlorentzon oscarlorentzon added this to the 2.18.1 milestone Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oscarlorentzon oscarlorentzon

Labels
bug
Projects
None yet
Milestone
2.18.1
Development

No branches or pull requests
1 participant
@oscarlorentzon