-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upload trips over GoPro Hero 9 spaces in sub_sec field #388
Comments
Thanks for reporting the issue and providing the test data! |
Warning ! It's a bug from Gopro, and this "hack" could generate some other problems as the subsecond is wrong! |
Thanks @Stefal for the information. What problem do you think it will cause? I will reopen it and investigate it later. |
If the real subsec value is an equivalent of 5ms, it will be stored in the Gopro image as
None of these solution is good. I have my own script to fix this, it checks the length of the subsectimeoriginal value and insert some So you can insert some code in the mapillary-tools to check this:
But that's a lot of work for only one cam, with a bug which should be fix soon... I hope... btw: @breunigs, feel free to add some pressure on Gopro, and explain that this bug is a problem for you too. |
Basic information
0.6.0
Steps to reproduce behavior
I uploaded an attached image that fails to extract time taken because of the space in the subseconds field. I'm using
Expected behavior
It parses the subseconds just fine.
Actual behavior
It fails with
Warning, required geotag_process failed for image bla.JPG
, skipping the image. More generic error messages are repeated later.Additional information
I hacked in a
sub_sec.strip()
mapillary_tools/mapillary_tools/exif_read.py
Line 202 in d0544d0
I can provide more images if you want to test more. Images around the same area+time as the provided example one are being uploaded right now, if that's more convenient for you.
The text was updated successfully, but these errors were encountered: