Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upload trips over GoPro Hero 9 spaces in sub_sec field #388

Closed
breunigs opened this issue Mar 21, 2021 · 4 comments · Fixed by #490
Closed

upload trips over GoPro Hero 9 spaces in sub_sec field #388

breunigs opened this issue Mar 21, 2021 · 4 comments · Fixed by #490

Comments

@breunigs
Copy link

breunigs commented Mar 21, 2021

Basic information

  • Release version: 0.6.0
  • System: Linux
  • Capture Device: GoPro Hero 9

Steps to reproduce behavior

I uploaded an attached image that fails to extract time taken because of the space in the subseconds field. I'm using

mapillary_tools process_and_upload --import_path --user_name breunigs --advanced --interpolate_direction

G0256237

Expected behavior

It parses the subseconds just fine.

Actual behavior

It fails with Warning, required geotag_process failed for image bla.JPG, skipping the image. More generic error messages are repeated later.

Additional information

I hacked in a sub_sec.strip()

seconds=float("0." + sub_sec)
and this seems to fix the issue… well, I only take pictures once every second, so even if this is not a proper fix, I might not see it.

I can provide more images if you want to test more. Images around the same area+time as the provided example one are being uploaded right now, if that's more convenient for you.

@breunigs breunigs changed the title mapillary upload trips over GoPro Hero 9 spaces in sub_sec field Apr 2, 2021
@ptpt ptpt closed this as completed in d272f68 Apr 28, 2021
@ptpt
Copy link
Member

ptpt commented Apr 28, 2021

Thanks for reporting the issue and providing the test data!

@Stefal
Copy link
Contributor

Stefal commented Jun 13, 2021

Warning ! It's a bug from Gopro, and this "hack" could generate some other problems as the subsecond is wrong!
I've reported this problem to Gopro here: https://community.gopro.com/t5/Cameras/subsecond-timestamp-bug/m-p/1057505

@ptpt
Copy link
Member

ptpt commented Jun 13, 2021

Thanks @Stefal for the information. What problem do you think it will cause? I will reopen it and investigate it later.

@ptpt ptpt reopened this Jun 13, 2021
@Stefal
Copy link
Contributor

Stefal commented Jun 13, 2021

If the real subsec value is an equivalent of 5ms, it will be stored in the Gopro image as . 50 and converted to .50. It is a 495ms offset. I see two solutions:

  • Ok, stay with this dirty workaround, but it could hide some problems and if someone is using a Hero 9 with a 0.5s timelapse, he could have some bad surprise with the image locations.
  • Let assume it's a bug from the Gopro..... not your problem. But it's a big drawback for Hero 9 users who want to use the mapillary-tools.

None of these solution is good.

I have my own script to fix this, it checks the length of the subsectimeoriginal value and insert some 0 if needed.

So you can insert some code in the mapillary-tools to check this:

  • is the cam a Gopro Hero 9
  • is the subsectimeoriginal value < 4
    If yes, insert the missing 0

But that's a lot of work for only one cam, with a bug which should be fix soon... I hope...

btw: @breunigs, feel free to add some pressure on Gopro, and explain that this bug is a problem for you too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants