Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set timeout for requests #495

Merged
merged 4 commits into from
Jan 15, 2022
Merged

fix: set timeout for requests #495

merged 4 commits into from
Jan 15, 2022

Conversation

ptpt
Copy link
Member

@ptpt ptpt commented Jan 15, 2022

The default timeout for requests is None, which will wait forever.
This PR sets the upload timeout to 10 minutes, and the other request timeouts to 1 minute.

  • fix: add timeouts for all HTTP requests
  • Simplify retryable error messages

@ptpt ptpt merged commit f51fd0f into main Jan 15, 2022
@ptpt ptpt deleted the fix-set-requests-timeout branch January 15, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants