-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: V2.0.0 #3
Closed
feat: V2.0.0 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update README.md * Update README.md * Update README.md Co-authored-by: Lucas Manuel <lucas@maple.finance>
* feat: Remove Loan Managers * fix: package and readme
* feat: remove obsolete routing * test: add unit tests for provide cover * fix: remove has sufficient cover * fix: add has sufficient cover back * fix: add fund and accept new terms functions * fix: add setminratio and setallowedslippage * fix: add default functions * fix: address pr comments * fix: add todos for removing config setters
…arams (SC-11363) (#250) * feat: remove ability to remove a LM from the PM * feat: update addLoanManager() to create instance and add to PM * feat: remove check of duplicate LM as its now redundent * feat: update tests * fix: adjust PR comments * feat: cache globals --------- Co-authored-by: JG <jg@jgcarv.com>
…functions (#251) * feat: support funding and refi for otlm * feat: tests for propose new terms * feat: add not PD test * feat: structure pullFundsLoanManager tests * fix: update broken test * feat: remaining tests * refactor: validate loan type function * refactor: update funcitons * fix: compiler errors * feat: make contract updates as discussed in standup * feat: fix tests * feat: requestFunds tests * feat: add setIsLoanManager tests * fix: update tests --------- Co-authored-by: lucas-manuel <lucas@maple.finance> Co-authored-by: JG <jg@jgcarv.com>
* feat: [sc-11678] expose `loanManagerListLength` function * refactor: get rid of unnecessary initializer references - LoanManagers take `poolManager` as argument * feat: allow generic loan manager deployment - sc-11680 - sc-11676 - sc-11627 - sc-11628 * refactor: cleanup * feat: CompleteConfigurationTests * fix: PR review for `PoolDeployed` event * fix: PR review
…ull interface (#261) * fix: update pool deployer to use pool manager like instead of full interface * fix: add additional functions to pool manager like
* feat: update to isInstanceOf in lieu of isFactory * chore: update cov percentage * fix: address PR comments * formatting: update multiline require --------- Co-authored-by: lucas-manuel <lucas@maple.finance>
* fix: internal audit small fixes * fix: adjust PR comments * test: add require to prevent zero principal
* feat: globals `isFunctionPaused` * fix: small fix * feat: upgrade with `securityAdmin` * feat: all external pauseable * fix: add note explaining why dos attack is not possible on complete configuration # Conflicts: # contracts/PoolManager.sol * fix: update test ordering # Conflicts: # tests/PoolManager.t.sol * fix: update formatting --------- Co-authored-by: lucas-manuel <lucas@maple.finance>
* feat: add checks on new withdrawalManager * style: fix spacing * test: zero address case * fix: add more failure mode tests --------- Co-authored-by: lucas-manuel <lucasmanuel.tech@gmail.com>
* feat: `coverAmount == 0` check in PoolDeployer * fix: cleanup tests --------- Co-authored-by: lucas-manuel <lucasmanuel.tech@gmail.com>
…7] (SC-12058) (#272) * fix: update tests * fix: error --------- Co-authored-by: Michael De Luca <michael.deluca@circle-free.com>
* refactor: homogenize ACL [3S #8] (SC-12035) * fix: update formatting --------- Co-authored-by: lucas-manuel <lucasmanuel.tech@gmail.com>
* refactor: rename modifiers/helpers * fix: pr review --------- Co-authored-by: Michael De Luca <michael.deluca@circle-free.com>
LCOV of commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.