Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: V2.0.0 #3

Closed
wants to merge 32 commits into from
Closed

feat: V2.0.0 #3

wants to merge 32 commits into from

Conversation

JGcarv
Copy link
Contributor

@JGcarv JGcarv commented Jun 6, 2023

No description provided.

@JGcarv JGcarv self-assigned this Jun 6, 2023
JGcarv and others added 29 commits June 6, 2023 17:10
* Update README.md

* Update README.md

* Update README.md

Co-authored-by: Lucas Manuel <lucas@maple.finance>
* feat: Remove Loan Managers

* fix: package and readme
* feat: remove obsolete routing

* test: add unit tests for provide cover

* fix: remove has sufficient cover

* fix: add has sufficient cover back

* fix: add fund and accept new terms functions

* fix: add setminratio and setallowedslippage

* fix: add default functions

* fix: address pr comments

* fix: add todos for removing config setters
…arams (SC-11363) (#250)

* feat: remove ability to remove a LM from the PM

* feat: update addLoanManager() to create instance and add to PM

* feat: remove check of duplicate LM as its now redundent

* feat: update tests

* fix: adjust PR comments

* feat: cache globals

---------

Co-authored-by: JG <jg@jgcarv.com>
…functions (#251)

* feat: support funding and refi for otlm

* feat: tests for propose new terms

* feat: add not PD test

* feat: structure pullFundsLoanManager tests

* fix: update broken test

* feat: remaining tests

* refactor: validate loan type function

* refactor: update funcitons

* fix: compiler errors

* feat: make contract updates as discussed in standup

* feat: fix tests

* feat: requestFunds tests

* feat: add setIsLoanManager tests

* fix: update tests

---------

Co-authored-by: lucas-manuel <lucas@maple.finance>
Co-authored-by: JG <jg@jgcarv.com>
* feat: [sc-11678] expose `loanManagerListLength` function

* refactor: get rid of unnecessary initializer references

- LoanManagers take `poolManager` as argument

* feat: allow generic loan manager deployment

- sc-11680
- sc-11676
- sc-11627
- sc-11628

* refactor: cleanup

* feat: CompleteConfigurationTests

* fix: PR review for `PoolDeployed` event

* fix: PR review
…ull interface (#261)

* fix: update pool deployer to use pool manager like instead of full interface

* fix: add additional functions to pool manager like
* feat: update to isInstanceOf in lieu of isFactory

* chore: update cov percentage

* fix: address PR comments

* formatting: update multiline require

---------

Co-authored-by: lucas-manuel <lucas@maple.finance>
* fix: internal audit small fixes

* fix: adjust PR comments

* test: add require to prevent zero principal
* feat: globals `isFunctionPaused`

* fix: small fix

* feat: upgrade with `securityAdmin`

* feat: all external pauseable

* fix: add note explaining why dos attack is not possible on complete configuration

# Conflicts:
#	contracts/PoolManager.sol

* fix: update test ordering

# Conflicts:
#	tests/PoolManager.t.sol

* fix: update formatting

---------

Co-authored-by: lucas-manuel <lucas@maple.finance>
* feat: add checks on new withdrawalManager

* style: fix spacing

* test: zero address case

* fix: add more failure mode tests

---------

Co-authored-by: lucas-manuel <lucasmanuel.tech@gmail.com>
* feat: `coverAmount == 0` check in PoolDeployer

* fix: cleanup tests

---------

Co-authored-by: lucas-manuel <lucasmanuel.tech@gmail.com>
…7] (SC-12058) (#272)

* fix: update tests

* fix: error

---------

Co-authored-by: Michael De Luca <michael.deluca@circle-free.com>
* refactor: homogenize ACL [3S #8] (SC-12035)

* fix: update formatting

---------

Co-authored-by: lucas-manuel <lucasmanuel.tech@gmail.com>
* refactor: rename modifiers/helpers

* fix: pr review

---------

Co-authored-by: Michael De Luca <michael.deluca@circle-free.com>
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

LCOV of commit 5ce562a during Forge Tests (PR) #6

Summary coverage rate:
  lines......: 69.2% (332 of 480 lines)
  functions..: 67.0% (136 of 203 functions)
  branches...: 82.1% (156 of 190 branches)

Files changed coverage rate:
                                            |Lines       |Functions  |Branches    
  Filename                                  |Rate     Num|Rate    Num|Rate     Num
  ================================================================================
  contracts/PoolDeployer.sol                | 100%     25| 100%     3|75.0%      8
  contracts/PoolManager.sol                 |88.5%    165|78.2%    55|83.3%    108
  contracts/proxy/PoolManagerFactory.sol    | 100%      2| 100%     1| 100%      2
  contracts/proxy/PoolManagerInitializer.sol|94.1%     17|50.0%     4|91.7%     12
  tests/Pool.t.sol                          | 0.0%     46| 0.0%     7| 0.0%      2
  tests/PoolManager.t.sol                   | 0.0%     27| 0.0%     1|    -      0
  tests/PoolManagerFactory.t.sol            | 0.0%     10| 0.0%     1|    -      0
  tests/harnesses/PoolManagerHarness.sol    |80.0%      5|80.0%     5|    -      0
  tests/mocks/Mocks.sol                     |76.3%     97|65.2%    89|62.5%     24

@JGcarv JGcarv closed this Jun 6, 2023
@JGcarv JGcarv deleted the v2.0.0 branch June 6, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants