feat: add support for changing the receiver’s viewport to fit given bounds #133
Conversation
TimAlber
changed the title
|
@TimAlber It would be great if you could also add a simple example to the example app. That makes it easier to test this and it also showcases the feature. |
|
Thank you for the example. Do you also want to add a web implementation? If not, I'll create an issue and someone can add it later on. |
|
I think it makes most sense if you create an issue and someone can add it later on. |
example/lib/given_bounds.dart
Outdated
| padding: 25, | ||
| ); | ||
| }, | ||
| child: const Text('Set Bounds to Germanny'), |
There was a problem hiding this comment.
| child: const Text('Set Bounds to Germanny'), | |
| child: const Text('Set bounds to Germany'), |
There was a problem hiding this comment.
Ah, I also left this tiny review in "pending" mode 🤦♂️
example/lib/given_bounds.dart
Outdated
| padding: 25, | ||
| ); | ||
| }, | ||
| child: const Text('Set Bounds to Afrika'), |
There was a problem hiding this comment.
| child: const Text('Set Bounds to Afrika'), | |
| child: const Text('Set bounds to Africa'), |
example/lib/given_bounds.dart
Outdated
|
|
||
| class GivenBoundsPage extends ExamplePage { | ||
| GivenBoundsPage() | ||
| : super(const Icon(Icons.map_sharp), 'Changing given Bounds'); |
There was a problem hiding this comment.
| : super(const Icon(Icons.map_sharp), 'Changing given Bounds'); | |
| : super(const Icon(Icons.map_sharp), 'Changing given bounds'); |
|
I fixed those typos. |
|
I don't know why iOS doesn't build. Maybe try to restart it? |
|
@TimAlber Your contributions would also be interesting for the flutter-mapbox-gl repo where this plugin was forked from. Would you like to "upstream" your changes? If not, someone else could also do it. |
|
@m0nac0 I think it would be best if someone else could do that. |
Add a feature to fit the viewport to given coordinate bounds.