Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when changing line color (see #448) #15

Merged
merged 2 commits into from
Oct 14, 2021

Conversation

vberthet
Copy link

@vberthet vberthet commented Oct 6, 2021

@m0nac0 I've also change this to fix issue flutter-mapbox-gl/maps#448
I haven't tested it with other color format so i'm not sure it'll not break other case.

@m0nac0
Copy link
Collaborator

m0nac0 commented Oct 12, 2021

@vberthet Thank you for fixing the bug! Would you mind using Color.parseColor()? This is used by all other annotation controllers, e.g.:
https://github.com/m0nac0/flutter-maplibre-gl/blob/6619cfe618d44671a52489654193bd8258e8682a/android/src/main/java/com/mapbox/mapboxgl/CircleController.java#L49

Copy link
Collaborator

@m0nac0 m0nac0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@m0nac0 m0nac0 merged commit 3b68061 into maplibre:main Oct 14, 2021
@m0nac0
Copy link
Collaborator

m0nac0 commented Oct 14, 2021

Side note: while reviewing this I found flutter-mapbox-gl/maps#562, which is also related to color handling in the android part. But that's a different issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants