Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable textureMode which was disabled in f8b2d1 #194

Merged
merged 3 commits into from
Feb 23, 2023

Conversation

maxammann
Copy link
Contributor

Similar to PR flutter-mapbox-gl/maps#1216 which I found after doing a git bisect.

maxammann added a commit to digitalfabrik/entitlementcard that referenced this pull request Feb 3, 2023
maxammann added a commit to digitalfabrik/entitlementcard that referenced this pull request Feb 6, 2023
* Fix throw error during init

* Upgrade flutter-maplibre to own fork until maplibre/flutter-maplibre-gl#194 is fixed
@mariusvn
Copy link
Contributor

@m0nac0 can you take a look, looks like new android versions are incompatible with the current versions

@GaelleJoubert
Copy link
Contributor

I tryed your fork, but I get the fllowing error : E/FrameEvents( 1394): updateAcquireFence: Did not find frame.

@m0nac0
Copy link
Collaborator

m0nac0 commented Feb 23, 2023

@maxammann Thank you for investigating this!

@GaelleJoubert Could you provide some more details about the error you are getting? Is the error only logged in the console or does the app crash/is the map not displayed etc.?

@m0nac0
Copy link
Collaborator

m0nac0 commented Feb 23, 2023

Since this is an important issue to fix, I'm merging this now. @GaelleJoubert Please let us know if you experience any serious issues with this PR.

@m0nac0 m0nac0 merged commit f8d9ab8 into maplibre:main Feb 23, 2023
@GaelleJoubert
Copy link
Contributor

I'll try and let you know !

@GaelleJoubert
Copy link
Contributor

Seems to work for me.
By the way, when adding a line layer with a geo json source, on android I have the issues :
Drawable fr.kip.app:drawable/mapbox_user_icon_shadow has unresolved theme attributes! Consider using Resources.getDrawable(int, Theme) or Context.getDrawable(int).
and
{GLThread 228}[ParseStyle]: Layer 'LaBEkRJZ1D_0' has an invalid value for text-font and will not render text. Output values must be contained as literals within the expression.

But, i don't see any visible issue other than the print on the log.

@m0nac0
Copy link
Collaborator

m0nac0 commented Feb 23, 2023

Ok good to hear. I'd say, if you experience any actual errors, open a new issue, if these are only printed to the log, ignore it for now.
(It would be good of course to investigate these in more detail, but I doubt anyone currently has the capacity to do that if its not actually causing problems)

@GaelleJoubert
Copy link
Contributor

Yeah, that's what I thought. No noticable issue for now, so no need to worry too much.
I just though i would mention these prints, in case they are relevent to someone.

@maxammann maxammann deleted the reenable-textureMode branch February 23, 2023 12:51
JanikoNaber pushed a commit to JanikoNaber/flutter-maplibre-gl that referenced this pull request Aug 23, 2023
Similar to PR flutter-mapbox-gl/maps#1216 which
I found after doing a git bisect.

Co-authored-by: m0nac0 <58807793+m0nac0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants