Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to suggestions list #14

Merged
merged 3 commits into from
Oct 28, 2021

Conversation

thaddmt
Copy link
Collaborator

@thaddmt thaddmt commented Oct 12, 2021

Overview

  • Set showResultMarkers to true by default
  • Change suggestions library to suggestions-list
    • suggestions-list forks suggestions to add feature support for not selecting any list items by default
  • Update geocoder enter keypress behavior
    • Previously would set the list value to the selected item and redo search API call with that input
    • Now in the geocoder it will check if a list item is active
      • If list item is active then geocoder will not call search API and will list the suggestions-list set the value and hide list results
      • If there is no list item active it will do a geocoder search API call

Checklist

  • briefly describe the changes in this PR
  • update CHANGELOG.md with changes under master heading before merging

@thaddmt thaddmt merged commit 72a3f02 into maplibre:main Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants