Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] added optional parameter which can toggle on/off searching while typing #5

Merged

Conversation

thaddmt
Copy link
Collaborator

@thaddmt thaddmt commented Aug 4, 2021

  • Added option showResultsWhileTyping (default: false)

    • When false requires enter key press to perform search
    • When true will automatically perform search when string is above minLength
  • briefly describe the changes in this PR

  • write tests for all new functionality

  • run npm run docs and commit changes to API.md

  • update CHANGELOG.md with changes under master heading before merging

API.md Show resolved Hide resolved
API.md Show resolved Hide resolved
API.md Show resolved Hide resolved
lib/index.js Show resolved Hide resolved
lib/index.js Show resolved Hide resolved
@thaddmt thaddmt merged commit c482559 into maplibre:main Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants