Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix bug where search cannot be done without fully clearing input #72

Merged
merged 2 commits into from
Jul 29, 2022
Merged

fix: fix bug where search cannot be done without fully clearing input #72

merged 2 commits into from
Jul 29, 2022

Conversation

thaddmt
Copy link
Collaborator

@thaddmt thaddmt commented Jul 26, 2022 •
edited

Overview

@thaddmt thaddmt requested a review from wipfli July 27, 2022 17:20
wipfli
wipfli requested changes Jul 27, 2022
View reviewed changes
Copy link
Member

@wipfli wipfli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this pull request @thaddmt Can you add a description of how to reproduce the problematic behavior before this pull request? Maybe in a separate issue bug report...

@thaddmt
Copy link
Collaborator Author

thaddmt commented Jul 27, 2022 •
edited

@wipfli yes! my bad forgot that the issue was filed in the amplify ui repo - #73

@thaddmt thaddmt requested a review from wipfli July 27, 2022 20:19
slaymance
slaymance approved these changes Jul 28, 2022
View reviewed changes
Copy link
Collaborator

@slaymance slaymance left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with a react application and this PR fixes the problem!

wipfli
wipfli approved these changes Jul 29, 2022
View reviewed changes
Copy link
Member

@wipfli wipfli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updated bug description in the issue, @thaddmt. Was able to reproduce it and this fixes the bug indeed.

@wipfli wipfli merged commit 62c8d82 into main Jul 29, 2022
@wipfli wipfli deleted the fix-searching-without-clear-input branch July 29, 2022 05:14
@thaddmt thaddmt mentioned this pull request Aug 9, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slaymance slaymance slaymance approved these changes

@wipfli wipfli wipfli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Geocoder requiring input to be cleared before searching for entire set of places after a single result search
3 participants
@thaddmt @slaymance @wipfli