Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terrain 3D zoom is reversed in high pitch, when pointing above horizon #3398

Closed
birkskyum opened this issue Nov 21, 2023 · 4 comments · Fixed by #3574
Closed

Terrain 3D zoom is reversed in high pitch, when pointing above horizon #3398

birkskyum opened this issue Nov 21, 2023 · 4 comments · Fixed by #3574
Assignees
Labels
bug Something isn't working enhancement New feature or request PR is more than welcomed Extra attention is needed Terrain 3D

Comments

@birkskyum
Copy link
Member

birkskyum commented Nov 21, 2023

Demo here: https://maplibre.org/maplibre-gl-js/docs/examples/3d-terrain/

Try holding the mouse over the white sky, and scroll - it'll move in the opposite direction compared to if the mouse is on a mountain.

I'm scrolling my mouse in the same direction direction all the time, but the map zoom in opposite direction depending on what i hover

Screen.Recording.2023-11-22.at.00.35.39.mov
@HarelM
Copy link
Member

HarelM commented Nov 22, 2023

Relevant discussion can be found here about this can be found here:
#3312

@HarelM HarelM added bug Something isn't working enhancement New feature or request Terrain 3D PR is more than welcomed Extra attention is needed labels Nov 22, 2023
@Pheonor
Copy link
Contributor

Pheonor commented Jan 14, 2024

@HarelM I have a fix for this issue. Could you assign it to me ?

Pheonor added a commit to Pheonor/maplibre-gl-js that referenced this issue Jan 14, 2024
@HarelM
Copy link
Member

HarelM commented Jan 15, 2024

@Pheonor let me know if you would like me to assign a bounty on this issue.

HarelM pushed a commit that referenced this issue Jan 15, 2024
* Use center for zoom when mouse above horizon (#3398).

* Compute horizon position relative to map center (i.e. height / 2).
@Pheonor
Copy link
Contributor

Pheonor commented Jan 15, 2024

Thank you @HarelM but I do not a bounty for this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request PR is more than welcomed Extra attention is needed Terrain 3D
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants