Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up CI / unit testing #4

Closed
nyurik opened this issue Dec 9, 2020 · 5 comments · Fixed by #38
Closed

Set up CI / unit testing #4

nyurik opened this issue Dec 9, 2020 · 5 comments · Fixed by #38
Projects
Initial release roadmap

Comments

@nyurik
Copy link
Member

nyurik commented Dec 9, 2020

Make all commits automatically go through (github actions?) tests.
@nyurik nyurik added the forking label Dec 9, 2020
@nyurik nyurik added this to To do in Initial release roadmap Dec 9, 2020
@jdesboeufs
Copy link

+1 for GitHub Actions

@jdesboeufs
Copy link

jdesboeufs commented Dec 9, 2020 •
edited
Loading

Unit tests run on Node.js 10 only.
But integration tests are too slow for GitHub Actions.

Do we add some build steps to the default workflow? Maybe build-css and build-prod-min?

@nyurik
Copy link
Member Author

nyurik commented Dec 9, 2020

First thing is to establish the same build/test pipeline as in mapbox-gl, and later we could change it in some way

@snickell
Copy link
Contributor

snickell commented Dec 10, 2020 •
edited
Loading

FYI, as of #17 being merged, I believe that a CI could execute tests (unit, integration, smoke, etc) by running:

./build/prepare-release.sh "yarn test"

@nyurik nyurik changed the title Set up unit testing Set up CI / unit testing Dec 12, 2020
@nyurik
Copy link
Member Author

nyurik commented Dec 12, 2020

It seems github actions will not work because the VMs do not have GPUs, so we will need to set up self hosted runner with GPU support. Hopefully it can be done with either Azure or Google Cloud.

@msbarry msbarry mentioned this issue Dec 15, 2020
Merged
Initial release roadmap automation moved this from To do to Done Dec 15, 2020
nyurik pushed a commit that referenced this issue Dec 15, 2020
@msbarry
Got github actions working (#38)
b8df294 
Fixes #4 by following instructions no the "gl" package to get it working on headless linux. I made progress on the windows build, but couldn't quite get it happy invoking bash script files from npm run scripts.

* fix github actions
* just comment out windows
@nyurik nyurik mentioned this issue Dec 15, 2020
Closed
@DavidBuerer DavidBuerer mentioned this issue Nov 2, 2022
Closed
9 tasks
mfedderly pushed a commit to mfedderly/maplibre-gl-js that referenced this issue Jan 23, 2023
@pgoldberg
Merge pull request maplibre#4 from acme/pgoldberg/changeUpAutorelease…
8c96a20 
…Config

try out default config
HarelM added a commit that referenced this issue Mar 29, 2023
@zhangyiatmicrosoft @tempranova @HarelM
Lazy serialization of layers (#2306)
3157c34 
* Lazy serialization of layers

* Lazy seri wip (#4)

* Warnonce for Terrain Source (#2298)

* check for terrain source with hillshade and issue warnonce

* changelog update

* add test and adjust indentation

* improve changelog note

* move test to bottom

* test updated to check console calls

* syntax for CI pass

---------

Co-authored-by: Harel M <harel.mazor@gmail.com>

* fix lint

* add test

* change log

---------

Co-authored-by: Victor Gerard Temprano <tempranova@users.noreply.github.com>
Co-authored-by: Harel M <harel.mazor@gmail.com>

* update expected bytes

* update and add UT

* update UT

* Update UT

* update UT to pass ci

* remove extra imports

---------

Co-authored-by: Victor Gerard Temprano <tempranova@users.noreply.github.com>
Co-authored-by: Harel M <harel.mazor@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Initial release roadmap
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Got github actions working msbarry/maplibre-gl-js
3 participants
@snickell @jdesboeufs @nyurik