Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove non-typed-modules #526

Closed
HarelM opened this issue Oct 18, 2021 · 1 comment
Closed

Remove non-typed-modules #526

HarelM opened this issue Oct 18, 2021 · 1 comment

Comments

@HarelM
Copy link
Member

HarelM commented Oct 18, 2021 •
edited

Motivation

After I found out the following code was broken I decided to create a PR to all the non-typed modules we use in order to avoid this in the future (as much as possible anyway).
#525

The following are the PR I made:
mapbox/vector-tile-js#78
mapbox/unitbezier#3
mapbox/mapbox-gl-supported#40
mapbox/potpack#7 - merged but not released

If all of these are merged and a new version is released with them the non-typed module file can be removed.
Relevant branch: 526-remove-non-typed-modules
@HarelM HarelM mentioned this issue Oct 24, 2021
Closed
@astridx astridx mentioned this issue Nov 5, 2021
Merged
@HarelM
Copy link
Member Author

HarelM commented Feb 11, 2022

This is now resolved.
Thanks @webberig!
Last PR related to this issue was #800

@HarelM HarelM closed this as completed Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@HarelM