Upgrade tiny sdf with latest typings #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bundle size report: Size Change: +5 B
ℹ️ View Details
|
@JinIgarashi can you help us with this? |
wipfli
reviewed
Oct 18, 2021
| bitmap: new AlphaImage({width: 30, height: 30}, tinySDF.draw(String.fromCharCode(id))), | ||
| bitmap: new AlphaImage({width: 30, height: 30}, tinySDF.draw(String.fromCharCode(id)).data), |
There was a problem hiding this comment.
In version 1 of TinySDF they had this:
TinySDF.prototype.draw = function (char) {
return this._draw(char, false).data;
};See https://github.com/mapbox/tiny-sdf/blob/2b1efa1ba63233c920f1116dbab64dc13a62c7e4/index.js#L152-L154 meaning that this change here seems correct to me.
wipfli
approved these changes
Oct 18, 2021
|
I would still want to see if I can find a way to add a test to make sure this is working as expected. |
|
I'll merge this and open an issue... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch Checklist
Seems like the tiny sdf upgrade was not done entirely correctly, I have submitted a PR to add typings and after I used it here it seems that the return value was changed too, but the code was not updated here.
I'm not sure how to test this unfortunately... :-(
See: mapbox/tiny-sdf#39