Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some events can be fired after Map#remove has been called when the WebGL context is lost and restored #726

Closed
vanilla-lake opened this issue Dec 22, 2021 · 1 comment
Closed

Some events can be fired after Map#remove has been called when the WebGL context is lost and restored #726

vanilla-lake opened this issue Dec 22, 2021 · 1 comment

Comments

@vanilla-lake
Copy link
Contributor

vanilla-lake commented Dec 22, 2021 •
edited

maplibre-gl-js version: 1.15.2

Steps to Trigger Behavior

  1. Create a Map.
  2. Register a "webglcontextlost" event handler on the Map that registers a "move" event handler and then calls Map#remove followed by WEBGL_lose_context#restoreContext.
  3. Call WEBGL_lose_context#loseContext.
  4. Notice that the "move" event fires even though the map has been removed.

Link to Demonstration

https://jsbin.com/buzucagaqo/1/edit?html,console

Expected Behavior

The "move" event should not fire after Map#remove has been called.

Actual Behavior

The "move" event fires after Map#remove has been called.
vanilla-lake added a commit to vanilla-lake/maplibre-gl-js that referenced this issue Dec 22, 2021
@vanilla-lake
Fix events being fired after Map#remove has been called when the WebG…
5653244 
…L context is lost and restored (maplibre#726)
@vanilla-lake vanilla-lake mentioned this issue Dec 22, 2021
Merged
5 tasks
HarelM pushed a commit that referenced this issue Dec 22, 2021
@vanilla-lake
Fix events being fired after Map#remove has been called when the WebG…
d375def 
…L context is lost and restored (#726) (#727)

* Fix events being fired after Map#remove has been called when the WebGL context is lost and restored (#726)

* Remove "webglcontextlost" event listener in Map#remove
@HarelM
Copy link
Member

HarelM commented Dec 22, 2021

Fixed by #727

@HarelM HarelM closed this as completed Dec 22, 2021
davenquinn added a commit to davenquinn/maplibre-gl-js that referenced this issue Dec 29, 2021
@davenquinn
Merge branch 'main' into pluggable-render
61fd24c 
* main: (98 commits)
  [Jest] Migrate `geojson_worker_source.test.js` (maplibre#731)
  Fix events being fired after Map#remove has been called when the WebGL context is lost and restored (maplibre#726) (maplibre#727)
  Define return type of getSource as possibly undefined (maplibre#724)
  Fix attibution controll (maplibre#668)
  Fix start-debug to watch ts files (maplibre#704)
  [Jest] Migrate `touch_zoom_rotate.test.js` (maplibre#721)
  [Jest] Migrate `requestRenderFrame.test.js` (maplibre#722)
  [Jest] Migrate `scroll_zoom.test.js` (maplibre#712)
  [Jest] Migrate `marker.test.js` (maplibre#696)
  [Jest] Migrate `mouse_rotate.test.js` (maplibre#711)
  [Jest] Migrate `keyboard.test.js` (maplibre#707)
  [Jest] Migrate `map_event.test.js` (maplibre#710)
  [Jest] Migrate `drag_rotate.test.js` (maplibre#709)
  Handle spies and call counts (maplibre#708)
  [Jest] Migrate `drag_pan.test.js` (maplibre#702)
  Add type for styleimagemissing event (maplibre#703)
  Fix MapDataEvent#isSourceLoaded being true in GeoJSONSource "dataloading" event handlers (maplibre#694) (maplibre#695)
  [Jest] Migrate `dblclick_zoom.test.js` (maplibre#697)
  [Jest] Migrate `popup.test.js` (maplibre#687)
  Fixed typo (maplibre#698)
  ...
davenquinn added a commit to davenquinn/maplibre-gl-js that referenced this issue Feb 9, 2022
@davenquinn
Merge branch 'pluggable-render' into hillshading-first-pass
8f83384 
* pluggable-render: (102 commits)
  WIP - pluggable render update
  Removed a badly typed variable
  [Jest] Migrate `geojson_worker_source.test.js` (maplibre#731)
  Fix events being fired after Map#remove has been called when the WebGL context is lost and restored (maplibre#726) (maplibre#727)
  Define return type of getSource as possibly undefined (maplibre#724)
  Fix attibution controll (maplibre#668)
  Fix start-debug to watch ts files (maplibre#704)
  Filter out hillshade layers
  Filter out hillshade styles
  [Jest] Migrate `touch_zoom_rotate.test.js` (maplibre#721)
  [Jest] Migrate `requestRenderFrame.test.js` (maplibre#722)
  [Jest] Migrate `scroll_zoom.test.js` (maplibre#712)
  [Jest] Migrate `marker.test.js` (maplibre#696)
  [Jest] Migrate `mouse_rotate.test.js` (maplibre#711)
  [Jest] Migrate `keyboard.test.js` (maplibre#707)
  [Jest] Migrate `map_event.test.js` (maplibre#710)
  [Jest] Migrate `drag_rotate.test.js` (maplibre#709)
  Handle spies and call counts (maplibre#708)
  [Jest] Migrate `drag_pan.test.js` (maplibre#702)
  Add type for styleimagemissing event (maplibre#703)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HarelM @vanilla-lake