Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate style spec files from mapbox to maplibre #147

Merged
merged 8 commits into from May 1, 2021

Conversation

wipfli
Copy link
Member

@wipfli wipfli commented May 1, 2021

This pull request replaces mapbox with maplibre across files in the src/style-spec directory. It also removes the --validate-mapbox-api-supported flag of the gl-style-validate utility, since this is specific to the mapbox.com API. Note that gl-style-validate still works for validating style files in general.

  • ✅ confirm your changes do not include backports from Mapbox projects (unless with compliant license)
  • ✅ briefly describe the changes in this PR
  • include before/after visuals or gifs if this PR includes visual changes
  • write tests for all new functionality
  • document any changes to public APIs
  • post benchmark scores
  • manually test the debug page
  • ✅ apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • ✅ add an entry inside this element for inclusion in the maplibre-gl-js changelog: <changelog></changelog>

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2021

Bundle size report:

Size Change: 0 B
Total Size Before: 205 kB
Total Size After: 205 kB

Output file Before After Change
maplibre-gl.js 196 kB 196 kB 0 B
maplibre-gl.css 8.87 kB 8.87 kB 0 B
ℹ️ View Details No major changes

@wipfli wipfli merged commit c47d053 into maplibre:main May 1, 2021
@wipfli wipfli deleted the publish-style-spec-3 branch May 1, 2021 19:19
@wipfli
Copy link
Member Author

wipfli commented May 1, 2021

the publish-style-spec.yml action now produced this in a npm publish --dry-run:

npm notice 
npm notice 📦  @maplibre/maplibre-gl-style-spec@13.17.0
npm notice === Tarball Contents === 
npm notice 71B     .eslintrc                              
npm notice 0       dist/.gitkeep                          
npm notice 252B    bin/gl-style-composite                 
npm notice 627B    bin/gl-style-format                    
npm notice 246B    bin/gl-style-migrate                   
npm notice 1.0kB   bin/gl-style-validate                  
npm notice 3.8kB   expression/definitions/assertion.js    
npm notice 2.0kB   expression/definitions/at.js           
npm notice 2.5kB   expression/definitions/case.js         
npm notice 3.2kB   expression/definitions/coalesce.js     
npm notice 4.9kB   expression/definitions/coercion.js     
npm notice 2.9kB   expression/definitions/collator.js     
npm notice 1.7kB   expression/types/collator.js           
npm notice 3.4kB   util/color_spaces.js                   
npm notice 2.4kB   util/color.js                          
npm notice 7.1kB   expression/definitions/comparison.js   
npm notice 1.2kB   composite.js                           
npm notice 5.7kB   expression/compound_expression.js      
npm notice 7.5kB   feature_filter/convert.js              
npm notice 9.3kB   function/convert.js                    
npm notice 1.3kB   declass.js                             
npm notice 749B    util/deep_equal.js                     
npm notice 1.2kB   deref.js                               
npm notice 13.8kB  diff.js                                
npm notice 686B    empty.js                               
npm notice 1.6kB   expression/evaluation_context.js       
npm notice 903B    expression/expression.js               
npm notice 1.1kB   migrate/expressions.js                 
npm notice 211B    util/extend.js                         
npm notice 5.1kB   expression/definitions/format.js       
npm notice 1.6kB   format.js                              
npm notice 2.4kB   expression/types/formatted.js          
npm notice 417B    util/get_type.js                       
npm notice 194B    flow-typed/gl.js                       
npm notice 1.9kB   group_by_layout.js                     
npm notice 1.5kB   expression/definitions/image.js        
npm notice 2.4kB   expression/definitions/in.js           
npm notice 3.2kB   expression/definitions/index_of.js     
npm notice 436.1kB dist/index.es.js                       
npm notice 465.8kB dist/index.js                          
npm notice 14.5kB  expression/definitions/index.js        
npm notice 16.7kB  expression/index.js                    
npm notice 5.3kB   feature_filter/index.js                
npm notice 10.5kB  function/index.js                      
npm notice 10.0kB  expression/definitions/interpolate.js  
npm notice 527B    util/interpolate.js                    
npm notice 1.7kB   expression/is_constant.js              
npm notice 459B    flow-typed/jsdom.js                    
npm notice 52B     reference/latest.js                    
npm notice 401B    validate/latest.js                     
npm notice 1.8kB   expression/definitions/length.js       
npm notice 2.1kB   expression/definitions/let.js          
npm notice 2.3kB   expression/definitions/literal.js      
npm notice 278B    flow-typed/mapbox-gl-supported.js      
npm notice 488B    flow-typed/mapbox-unitbezier.js        
npm notice 2.6kB   validate/validate.js                   
npm notice 529B    error/validation_error.js              
npm notice 3.8kB   expression/values.js                   
npm notice 1.3kB   expression/definitions/var.js          
npm notice 1.1kB   flow-typed/vector-tile.js              
npm notice 2.4kB   visit.js                               
npm notice 11.9kB  expression/definitions/within.js       
npm notice 1.3kB   package.json                           
npm notice 175.2kB reference/v8.json                      
npm notice 720.8kB dist/index.es.js.map                   
npm notice 720.9kB dist/index.js.map                      
npm notice 23.1kB  CHANGELOG.md                           
npm notice 1.5kB   feature_filter/README.md               
npm notice 1.5kB   README.md                              
npm notice === Tarball Details === 
npm notice name:          @maplibre/maplibre-gl-style-spec        
npm notice version:       13.17.0                                 
npm notice package size:  590.9 kB                                
npm notice unpacked size: 2.8 MB                                  
npm notice shasum:        894557831bcd8ca6859f03e8d4cc4b3e2d11d592
npm notice integrity:     sha512-8JNl5l4BTOzwc[...]nXN2EMOs/URGw==
npm notice total files:   119                                     
npm notice 

@wipfli
Copy link
Member Author

wipfli commented May 1, 2021

What do you think @nyurik?

@wipfli wipfli mentioned this pull request May 1, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants