Move terrain object to map (part of elevation freeze fix) #1628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bundle size report: Size Change: +1 B
ℹ️ View DetailsNo major changes |
|
Thank you @HarelM . Great! But until wednesdey i am not in front of a computer, i will review asap next week. |
|
You can do it from the phone :-) the change here is only the moving of the object, fairly simple. |
birkskyum
approved these changes
Sep 8, 2022
|
Nope, this is the terrain validation as part of the style spec. |
HarelM
added a commit
that referenced
this pull request
Sep 8, 2022
* add freezeElevation logic to AnimationOptions * flyTo and easeTo calculates camera-height in respect of target height in terrain * fix recalculation of _elevationStart during easing * fix tests * fix reviewing comments * Move terrain object to map (#1628) Co-authored-by: HarelM <harel.mazor@gmail.com>
cns-solutions-admin
pushed a commit
to CNS-Solutions/maplibre-gl-js
that referenced
this pull request
Sep 21, 2022
* add freezeElevation logic to AnimationOptions * flyTo and easeTo calculates camera-height in respect of target height in terrain * fix recalculation of _elevationStart during easing * fix tests * fix reviewing comments * Move terrain object to map (maplibre#1628) Co-authored-by: HarelM <harel.mazor@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@prozessor13 I've done the coding part of moving the object.
Please review.
I think it's OK, but I touched a lot of files...