Add helpful guideline for contributors #2212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proposed update to the Contributor's guidelines based on Slack discussion.
If these are to apply to multiple repositories, maybe maplibre/maplibre is a better place to add it. With a link from the respective repositories. |
|
Some of the instructions I added are specific to gl-js / npm, so it's not a perfect copy/paste. |
|
@ZeLonewolf Yes now I read it a bit more closely, we work with design proposals for significant changes in MapLibre GL Native, so it is definitely a different process there. |
louwers
reviewed
Feb 20, 2023
louwers
reviewed
Feb 20, 2023
|
@ZeLonewolf can you please resolve the latest comments so this can be merged? |
Update per discussion
Update note about the TSC
|
Updated per discussion. |
louwers
reviewed
Mar 1, 2023
louwers
reviewed
Mar 1, 2023
louwers
reviewed
Mar 1, 2023
louwers
approved these changes
Mar 1, 2023
Co-authored-by: Bart Louwers <bart.louwers@gmail.com>
Co-authored-by: Bart Louwers <bart.louwers@gmail.com>
Co-authored-by: Bart Louwers <bart.louwers@gmail.com>
HarelM
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the contributor's guide with recommendations interacting with the team, based on Slack discussions.