Docs: Example for stylemissingimage #2258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `imageId` to the logged output - Add TypeScript type for event
HarelM
approved these changes
Mar 8, 2023
|
THANKS! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is supposed to improve the example at https://maplibre.org/maplibre-gl-js-docs/api/map/#map.event:styleimagemissing by…
imageIdto the logged output and implicitly explaining in the code thatevent.idis the image's idMy understanding is, that those docs are generated based on this code, right?
Had to add a fix commit. Let me know if I should squash manually of if you could squash on merge. Happy to do it, if this is a change that might get accepted…