Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow auto merge to Dependabot PR if they pass CI #2345

Merged
merged 2 commits into from
Apr 5, 2023

Conversation

HarelM
Copy link
Member

@HarelM HarelM commented Apr 4, 2023

Enable auto merge to dependent bot if CI passes.

Heavily relies on https://rednafi.github.io/reflections/automerge-dependabot-prs-on-github.html

I've been spending a lot of time simply clicking approve on dependant bot PRs.
I hope this will reduce the time I need to spend on this.

@birkskyum @zhangyiatmicrosoft

Enable auto merge to dependent bot if CI passes.
IvanSanchez added a commit to Leaflet/Leaflet that referenced this pull request Apr 4, 2023
This is a blatant copy of @HarelM's maplibre/maplibre-gl-js#2345 . Should ease up maintenance a bit.
@wipfli
Copy link
Member

wipfli commented Apr 4, 2023

@stepankuzmin has something like that for Martin. Feel free to copy from there

@HarelM
Copy link
Member Author

HarelM commented Apr 4, 2023

Thanks for the info! I see that they have automatic approve there as well, I'll add that too.

@stepankuzmin
Copy link
Contributor

@HarelM
Copy link
Member Author

HarelM commented Apr 4, 2023

Thanks @stepankuzmin! I've updated the action according to the example in martin.

@birkskyum
Copy link
Member

birkskyum commented Apr 4, 2023

It's a good idea, but it has to run tests for each commit - had issues in the past that it merged a ton of commits at once, some of which were incompatible, so each commit has to invalidate the existing checks. Having dependabot only open one ticket at a time could be a reasonable way to enforce it and at the same time avoid spending time making checks that would later be invalidated.

@HarelM
Copy link
Member Author

HarelM commented Apr 4, 2023

I think it will run the tests as far as I read.

@HarelM HarelM merged commit edfaa54 into main Apr 5, 2023
@HarelM HarelM deleted the auto-merge-dependantbot branch April 5, 2023 21:48
@HarelM
Copy link
Member Author

HarelM commented Apr 5, 2023

Let's see how it works, worst case we remove this...

@wipfli
Copy link
Member

wipfli commented Apr 6, 2023

The dependabot open pull request limit is at 20 I think currently. If you get too many incompatibility conflicts, you might want to turn this number down again...

@HarelM HarelM mentioned this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants