Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) GeolocateControl error if removed quickly #2391

Merged
merged 2 commits into from
Apr 14, 2023
Merged

(fix) GeolocateControl error if removed quickly #2391

merged 2 commits into from
Apr 14, 2023

Conversation

Pessimistress
Copy link
Contributor

@Pessimistress Pessimistress commented Apr 13, 2023 •
edited
Loading

Closes #2387

  • Add a unit test for the bug
  • Check if control is still mounted before setting up UI

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

@HarelM HarelM merged commit a511f2c into maplibre:main Apr 14, 2023
@HarelM
Copy link
Member

HarelM commented Apr 14, 2023

THANKS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarelM HarelM HarelM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GeolocateControl throws if removed too quickly
2 participants
@Pessimistress @HarelM