Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise description of localIdeographFontFamily example #3018

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Revise description of localIdeographFontFamily example #3018

merged 1 commit into from
Aug 22, 2023

Conversation

bdon
Copy link
Contributor

@bdon bdon commented Aug 22, 2023

Launch Checklist

The docs https://maplibre.org/maplibre-gl-js/docs/examples/local-ideographs/ state the opposite of what this setting actually does. Sped-up map load times with local ideographs is the default, and no setting is necessary, but setting it to false will disable local ideographs. Finally, setting the value only specifies device font fallbacks that override the style.

Related to #2990

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Add an entry to CHANGELOG.md under the ## main section.

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (249c830) 75.02% compared to head (994ece2) 75.02%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3018   +/-   ##
=======================================
  Coverage   75.02%   75.02%           
=======================================
  Files         240      240           
  Lines       19122    19122           
  Branches     4315     4315           
=======================================
  Hits        14346    14346           
  Misses       4776     4776           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM HarelM enabled auto-merge (squash) August 22, 2023 10:21
@HarelM HarelM merged commit 036d589 into maplibre:main Aug 22, 2023
14 checks passed
@bdon bdon deleted the use-local-ideographs-example branch August 22, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants