Remove CJK browser test #3162
Merged
Remove CJK browser test #3162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3162 +/- ##
=======================================
Coverage 75.09% 75.09%
=======================================
Files 240 240
Lines 19150 19150
Branches 4323 4323
=======================================
Hits 14380 14380
Misses 4770 4770 ☔ View full report in Codecov by Sentry. |
8 tasks
neodescis
reviewed
Oct 3, 2023
| test('Marker: correct position', async () => { | ||
| const markerScreenPosition = await page.evaluate(() => { | ||
| const markerMapPosition = [11.40, 47.30]; | ||
| const markerMapPosition = [11.40, 47.30] as [number, number]; |
There was a problem hiding this comment.
Maybe this doesn't matter, but I would usually prefer to write this as follows to avoid a "cast":
const markerMapPosition: [number, number] = [11.40, 47.30];
neodescis
approved these changes
Oct 3, 2023
8 tasks
HarelM
pushed a commit
that referenced
this pull request
Oct 6, 2023
* Port CJK browser test to render test [#3006, #3162] * add platform-specific expected images for local ideographs render test. [#3166] * Ubuntu expected is tofu * github actions ubuntu runner: apt install CJK fonts for render tests [#3166] * Commit expected Ubuntu local ideographs image with noto fonts installed from apt [#3166]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the CJK test - the png parse was never observed, the diff was too strict and using base64 text isn't a great way to see what is the expected images.
In the past the render test were ran in node, but now they are running in the browser, so this test is not needed anymore.