Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

localIdeographs render test set pixelRatio = 2 [#3006] #3186

Merged
merged 2 commits into from
Oct 7, 2023
Merged

localIdeographs render test set pixelRatio = 2 [#3006] #3186

merged 2 commits into from
Oct 7, 2023

Conversation

bdon
Copy link
Contributor

@bdon bdon commented Oct 7, 2023

@HarelM I should have set this in the previous PR #3166 . This simulates a "retina" device such that the next changeset in #3006 is more clear. (Will let CI fail and then update committed expected images with new 2x size images.)

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e5dd5a0) 75.11% compared to head (75c5595) 75.11%.
Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3186   +/-   ##
=======================================
  Coverage   75.11%   75.11%           
=======================================
  Files         240      240           
  Lines       19170    19170           
  Branches     4325     4325           
=======================================
  Hits        14400    14400           
  Misses       4770     4770           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdon
Copy link
Contributor Author

bdon commented Oct 7, 2023

Images added, PTAL

@HarelM HarelM merged commit 9f7e2a9 into maplibre:main Oct 7, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants