Add registry url to allow publishing npm package #3341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3341 +/- ##
=======================================
Coverage 75.45% 75.45%
=======================================
Files 241 241
Lines 19260 19260
Branches 4339 4339
=======================================
Hits 14532 14532
Misses 4728 4728 ☔ View full report in Codecov by Sentry. |
|
I think this is it: Take away message: Always make sure you have good defaults... :-/ |
louwers
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this would solve the issue.
If now, I can try and revert to the previous definition of the node version, it might help, IDK...
Based on this:
npm/cli#6184 (comment)