Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change geojson source API to use promises #3421

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Conversation

HarelM
Copy link
Member

@HarelM HarelM commented Nov 28, 2023

Change the geojson source API from using callbacks to using promises.
Also changed the examples to use that and verified that they work.

@HarelM HarelM changed the title Change geojson source API Change geojson source API to use promises Nov 28, 2023
@HarelM HarelM enabled auto-merge (squash) November 28, 2023 21:58
@codecov-commenter
Copy link

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (10af384) 75.50% compared to head (6e70163) 75.56%.
Report is 13 commits behind head on main.

Files Patch % Lines
src/source/rtl_text_plugin_worker.ts 59.09% 9 Missing ⚠️
src/source/worker.ts 35.71% 9 Missing ⚠️
src/source/geojson_source.ts 0.00% 6 Missing ⚠️
src/data/bucket/symbol_bucket.ts 66.66% 1 Missing ⚠️
src/style/evaluation_parameters.ts 50.00% 1 Missing ⚠️
src/symbol/transform_text.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3421      +/-   ##
==========================================
+ Coverage   75.50%   75.56%   +0.05%     
==========================================
  Files         241      242       +1     
  Lines       19230    19201      -29     
  Branches     4271     4259      -12     
==========================================
- Hits        14520    14509      -11     
+ Misses       4710     4692      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM HarelM merged commit ef5a2fa into main Nov 28, 2023
14 checks passed
@HarelM HarelM deleted the change-geojson-source-api branch November 28, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants