Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove silent abort from ajax calls #3436

Merged
merged 2 commits into from
Dec 3, 2023
Merged

Remove silent abort from ajax calls #3436

merged 2 commits into from
Dec 3, 2023

Conversation

HarelM
Copy link
Member

@HarelM HarelM commented Dec 3, 2023

Seems like this need to be solved sooner rather than later.
Fixes #3435.
Fixes #3308.

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (47d7403) 75.58% compared to head (caf5956) 75.60%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/util/ajax.ts 50.00% 3 Missing ⚠️
src/source/image_source.ts 0.00% 1 Missing ⚠️
src/util/dispatcher.ts 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3436      +/-   ##
==========================================
+ Coverage   75.58%   75.60%   +0.02%     
==========================================
  Files         243      243              
  Lines       19183    19163      -20     
  Branches     4247     4243       -4     
==========================================
- Hits        14499    14488      -11     
+ Misses       4684     4675       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM
Copy link
Member Author

HarelM commented Dec 3, 2023

I was under the impression something will fail, guess the code is in a better shape than I thought...

@HarelM HarelM marked this pull request as ready for review December 3, 2023 13:22
@neodescis neodescis changed the title Remove silent about from ajax calls Remove silent abort from ajax calls Dec 3, 2023
@HarelM HarelM enabled auto-merge (squash) December 3, 2023 19:07
@HarelM HarelM merged commit 0cec13c into main Dec 3, 2023
14 checks passed
@HarelM HarelM deleted the remove-silent-abort branch December 3, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raster tiles stop being loaded after fast zooming / panning Reject abort errors in ajax.js and actor.ts
3 participants