Upgrade node to version 20 #3452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louwers
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Two weeks ago something was merged to disable specific warning types. May be good to look at this at some point. nodejs/node#47478
|
Forgot to disable auto merge... :-/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades node to version 20, also removed unwanted console log.
Removed
glpackage as it's an overkill for the unit test and jest can mock most of it.Replaced
jest-canvas-mockwithjest-webgl-canvas-mockwhich is a fork that allows to mock some of the webgl methods.If the following is merged some mocking can be removed.