Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set terrain from diff #3515

Merged
merged 10 commits into from
Jan 9, 2024
Merged

Set terrain from diff #3515

merged 10 commits into from
Jan 9, 2024

Conversation

HarelM
Copy link
Member

@HarelM HarelM commented Dec 28, 2023

Launch Checklist

Fixes #3463 - add support for terrain in diff

This depends on the following PR to be merged and published first:

Also added some types to pick method.

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (b25764e) 85.88% compared to head (e707f46) 85.90%.

Files Patch % Lines
src/style/style.ts 95.94% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3515      +/-   ##
==========================================
+ Coverage   85.88%   85.90%   +0.02%     
==========================================
  Files         244      244              
  Lines       48174    48213      +39     
  Branches     5126     5147      +21     
==========================================
+ Hits        41374    41418      +44     
+ Misses       6800     6795       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM HarelM marked this pull request as ready for review January 9, 2024 10:13
@HarelM
Copy link
Member Author

HarelM commented Jan 9, 2024

The 3 missing lines in the coverage report are related to a situation where the diffStyle function from the style spec package returns a different operation than expected.
I'm not sure it's worth the extra effort of trying to mock the diffStyle method in order to cover this code, it's mostly a safeguard.

This is now ready for review.

@HarelM HarelM requested a review from birkskyum January 9, 2024 10:32
@HarelM HarelM merged commit ebd9875 into main Jan 9, 2024
15 checks passed
@HarelM HarelM deleted the set-terrain-from-diff branch January 9, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When updating the style with diff:true and terrain change the map doesn't change
4 participants