Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set padding-top: 15px for popup card. #354

Merged
merged 2 commits into from
Nov 18, 2021

Conversation

naogify
Copy link
Contributor

@naogify naogify commented Sep 18, 2021

Close #338

When I set a popup on a marker and click on it, the focus is on the close button (x) and part of the text in the popup is hidden. This happens only when you click on the marker for the first time.

So, I changed the padding-top of the popup from 10px to 15px.

Before

スクリーンショット 2021-09-18 15 42 08

After

スクリーンショット 2021-09-18 15 42 51

Changelog

<changelog>Fix padding-top of the popup to improve readability of popup text (#354).</changelog>

Launch Checklist

  • confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • briefly describe the changes in this PR
  • include before/after visuals or gifs if this PR includes visual changes
  • write tests for all new functionality
  • document any changes to public APIs
  • post benchmark scores
  • manually test the debug page
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the maplibre-gl-js changelog: <changelog></changelog>

Copy link
Member

@HarelM HarelM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@HarelM
Copy link
Member

HarelM commented Sep 18, 2021

Forgot to ask: Please add this to the change log file.

@github-actions
Copy link
Contributor

Bundle size report:

Size Change: -1 B
Total Size Before: 194 kB
Total Size After: 194 kB

Output file Before After Change
maplibre-gl.js 185 kB 185 kB 0 B
maplibre-gl.css 9.49 kB 9.49 kB -1 B
ℹ️ View Details No major changes

@naogify
Copy link
Contributor Author

naogify commented Sep 21, 2021

@HarelM
I have added the changes to the change log. If you have something to fix, let me know!

@HarelM HarelM merged commit 50de937 into maplibre:main Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Part of the text in the popup is hidden by focus of close button.
2 participants