Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export types along the default export #3564

Merged
merged 8 commits into from
Jan 11, 2024
Merged

Export types along the default export #3564

merged 8 commits into from
Jan 11, 2024

Conversation

HarelM
Copy link
Member

@HarelM HarelM commented Jan 11, 2024

Launch Checklist

This should hopefully improve the future typings exported issues with both dts-bundle-generator and typedoc.
Also removed unused files and added typecheck to prevent future failures.

Fixes #3563

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Add an entry to CHANGELOG.md under the ## main section.

Before:
image
image

After:
No errors or warnings.

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b364c52) 85.91% compared to head (1546e10) 85.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3564      +/-   ##
==========================================
+ Coverage   85.91%   85.92%   +0.01%     
==========================================
  Files         244      244              
  Lines       48213    48262      +49     
  Branches     5150     5150              
==========================================
+ Hits        41421    41470      +49     
  Misses       6792     6792              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM HarelM merged commit a203720 into main Jan 11, 2024
15 checks passed
@HarelM HarelM deleted the fix-exported-map-3563 branch January 11, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.0.0-pre.3 does not export Map in typescript
3 participants