Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update popup methods addClass / removeClass to return popup instance #3975

Merged
merged 5 commits into from
Apr 25, 2024

Conversation

ferdicus
Copy link
Contributor

@ferdicus ferdicus commented Apr 11, 2024

As mentioned in discussion #3972

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

Return `this` (popup instance) one the `addClass` / `removeClass` methods.
@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.45%. Comparing base (f4249af) to head (a37eb7b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3975      +/-   ##
==========================================
+ Coverage   86.24%   86.45%   +0.20%     
==========================================
  Files         242      242              
  Lines       32515    32517       +2     
  Branches     2156     2145      -11     
==========================================
+ Hits        28042    28111      +69     
+ Misses       3507     3450      -57     
+ Partials      966      956      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM
Copy link
Member

HarelM commented Apr 11, 2024

Thanks for taking the time to open this PR!
Can you please add a changelog entry and a test to cover the newly added functionality?

@ferdicus
Copy link
Contributor Author

Thanks for taking the time to open this PR! Can you please add a changelog entry and a test to cover the newly added functionality?

Sorry, have seen this, it's not forgotten :D

Will come back to this during this week 🙇🏿

Sorry for the caused inconvenience

@ferdicus
Copy link
Contributor Author

@HarelM, would you kindly have another look

thanks 🙇🏿

CHANGELOG.md Outdated Show resolved Hide resolved
@HarelM HarelM enabled auto-merge (squash) April 25, 2024 10:57
@HarelM HarelM merged commit 6a10386 into maplibre:main Apr 25, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants