Fix to run benchmark with MAPLIBRE_STYLES environment variables #2122

[smellman]

Launch Checklist

Bugfix for #2122.

• Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
• Briefly describe the changes in this PR.
• Link to related issues.
• Include before/after visuals or gifs if this PR includes visual changes.
• Write tests for all new functionality.
• Document any changes to public APIs.
• Post benchmark scores.
• Add an entry to CHANGELOG.md under the ## main section.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.59%. Comparing base (aa023df) to head (9177637).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4098      +/-   ##
==========================================
+ Coverage   86.57%   86.59%   +0.01%     
==========================================
  Files         241      241              
  Lines       32535    32535              
  Branches     1986     1990       +4     
==========================================
+ Hits        28167    28173       +6     
+ Misses       3418     3414       -4     
+ Partials      950      948       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[HarelM]

Is this documented in a readme somewhere?
If not, can you please add instructions?

[smellman]

@HarelM https://github.com/maplibre/maplibre-gl-js/blob/main/test/bench/README.md#running-style-benchmarks Document is here.

[HarelM]

I think the require is needed when using local files and not public URLs.
I think it needs to be replaced with "import", which is async I believe.
Am I missing anything?

[smellman]

I think the require is needed when using local files and not public URLs. I think it needs to be replaced with "import", which is async I believe. Am I missing anything?

Oh, I don't care about local files.
I will check it.

[HarelM]

How about using readFileSync to reduce the complexity of this method?

[smellman]

Thanks you your comment, I will fix it.

[HarelM]

Thanks for taking the time to fix this!!

[smellman]

I fix to use readFileSync.