-
-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make aria-label
configurable for Map, Marker and Popup
#4147
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4147 +/- ##
==========================================
+ Coverage 86.73% 86.78% +0.04%
==========================================
Files 242 242
Lines 33071 33076 +5
Branches 2029 2040 +11
==========================================
+ Hits 28685 28704 +19
+ Misses 3402 3378 -24
- Partials 984 994 +10 ☔ View full report in Codecov by Sentry. |
Thanks! Can you add a changelog item please? |
5632170
to
3459cd5
Compare
<canvas>
aria-label via an i18n labelaria-label
configurable for Map, Marker and Popup
c10c641
to
4a9843c
Compare
Hi @HarelM, I've proceeded to a couple more changes as well as reflecting them with tests and CHANGELOG entries. We are in the process of auditing the accessibility of a map-heavy application (https://cartobio.agencebio.org) with the French guidelines (RGAA—a port of WCAG). So I'm happy to contribute more changes as we go along. |
4a9843c
to
591d294
Compare
Check out the following issues which are related to accessibility. I was unable to understand how to solve them, but you might be able to: Any progress in that front would be great. |
ec28586
to
5709a07
Compare
bbb31d9
to
48e83a1
Compare
48e83a1
to
a49644f
Compare
a49644f
to
dc275c2
Compare
Map
<canvas>
defaultaria-label
,Marker
defaultaria-label
andPopup
default close buttonaria-label
are made configurable to suit better the web page locale.Also, the
<canvas>
element is keyboard focusable (tabindex="0"
) only when the map is interactive. Otherwise, it acts as an illustration—maybe it should be reflected as arole="presentation"
attribute?Launch Checklist
CHANGELOG.md
under the## main
section.