Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set: forceConsistentCasingInFileNames rule to true (tsconfig) #4220

Merged

Conversation

coliff
Copy link
Contributor

@coliff coliff commented Jun 3, 2024

Set: forceConsistentCasingInFileNames rule to true (tsconfig)

This is recommended by Typescript:
https://typescriptlang.org/tsconfig/#forceConsistentCasingInFileNames

I've had this option set locally for and lint and test scripts complete without issues

I discovered this by using WebHint VS Code extension which also recommend using it.
https://webhint.io/docs/user-guide/hints/hint-typescript-config/consistent-casing

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

Set: forceConsistentCasingInFileNames rule to true (tsconfig)

This is recommended by Typescript:
https://typescriptlang.org/tsconfig/#forceConsistentCasingInFileNames

I've had this option set locally for and lint and test scripts complete without issues

I discovered this by using WebHint VS Code extension which also recommend using it. https://webhint.io/docs/user-guide/hints/hint-typescript-config/consistent-casing
@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.85%. Comparing base (f70ce60) to head (2d2682d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4220       +/-   ##
===========================================
- Coverage   87.57%   70.85%   -16.73%     
===========================================
  Files         242      241        -1     
  Lines       33082    33078        -4     
  Branches     2167     1257      -910     
===========================================
- Hits        28973    23437     -5536     
- Misses       3130     8384     +5254     
- Partials      979     1257      +278     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM HarelM enabled auto-merge (squash) June 3, 2024 16:00
@HarelM HarelM merged commit 9e2f2c4 into maplibre:main Jun 3, 2024
15 checks passed
@coliff coliff deleted the dev/coliff/forceConsistentCasingInFileNames branch June 3, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants