Allow pitch up to 85

[kibala145]

Changed allowed maxPitch value from 60 to 85. Closes #47

[kibala145]

Corrected version of #56.
The PR just changes maxPitch allowed value. No perfomance optimization for large pitch values added, by the way, should optimization be here or a separate PR?

Please tell me if I missed something.

[github-actions]

Bundle size report:

Size Change: 0 B
Total Size Before: 194 kB
Total Size After: 194 kB

Output file	Before	After	Change
maplibre-gl.js	185 kB	185 kB	0 B
maplibre-gl.css	9.49 kB	9.49 kB	0 B

ℹ️ View Details

Source file	Before	After	Change
rollup/build/tsc/src/ui/map.js	6.07 kB	6.07 kB	+2 B

[HarelM]

Thanks for this PR!
Please make sure to keep the template next time as you must acknowledge that this is not a backport of mapbox code.
Also please add a changelog item as part of this PR.

[HarelM]

P.S. Optimization can be done on another PR as the default wasn't changed as part of this PR and it's the user responsibility to make sure everything works as expected...

[HarelM]

I'm not sure I have a good solution for this, but it's worth noting somehow the the max pitch change is "at your own risk"...?

[rbrundritt]

I played around with overriding this in the past. Something worth calling out is that vector tiles that are in the distance may end up loading from an earlier zoom level. This particularly is noticeable when you setup zoom level ranges between two different layers. I wouldn't say this is a blocker, but something to be aware of. I also recall issues with the querySourceFeatures function not working correctly when pitched beyond 60 degrees in some cases, but can't seem to find the bug for this.

[kibala145]

I'm not sure I have a good solution for this, but it's worth noting somehow the the max pitch change is "at your own risk"...?

Sounds good. Could you please tell me where to add this?

[HarelM]

I'm honestly not sure, the best idea I have is to write it as part of the change log item you added...

[HarelM]

@rbrundritt I know this is probably not a perfect solution to this issue and more work is needed but I think that adding this will allow users to start explore this, find issues and hopefully try and fix them.
The full solution is probably way more complex and if you are not changing the default you wouldn't see these issues.
So I think this is a good addition, MVP style.

[HarelM]

@astridx @wipfli @xabbu42 let me know what you guys think about this.
I vote for merging this.

[xabbu42]

I think we should also add a warning to the documentation, as most users will not read old changelogs. Probably in https://maplibre.org/maplibre-gl-js-docs/api/map/#map#setmaxpitch.

[xabbu42]

And the documentation for option.maxPitch in the source itself should also include a short warning.

[rbrundritt]

How about a warning like this. "Max pitch values greater than 60 degrees are experimental and may result in rendering issues. If you encounter any, please raise an issue with details in the MapLibre project.".

[astridx]

I would also include this PR. Technically, I have no experience in working with the parameter. But since the default value remains and there is a warning, it should be fine.

[JannikGM]

There's a couple of issues with high pitch values that I had found in the past; here's what I remember:

• Can see very far into distance, so a lot of tiles are being loaded; this can pretty much cause your tile-cache to be flushed over and over and the tile-server will likely get DDoS'd.
• Camera placement in mapbox is relative to the point where the camera is looking at; because the point is closer to horizon (= distance closer to infinity), it gets numerically unstable, so your camera can get jerky.
• Map movement with swiping / dragging also encounters this numeric issue, but also logic errors, as even a tiny drag on the screen can result in a huge movement of the camera, as a couple of pixels towards the horizon can be huge distances; the existing navigation controls were not designed for this scenario.

[cigone-openindoor]

So now, how could we define sky color(s) ?

[rbrundritt]

So now, how could we define sky color(s) ?

What I did in one demo was add a gradient background color to the map div. For example using this CSS:

#myMap {
    background: linear-gradient(0deg, rgba(36,0,0,1) 56%, rgb(249 209 89) 62%, rgb(81 151 173) 80%, rgb(2 92 179) 95%)
}

and it turn out like this:

[cigone-openindoor]

Wonderful !